--- linux/fs/isofs/rock.c.orig +++ linux/fs/isofs/rock.c @@ -14,6 +14,7 @@ #include #include #include +#include #include "rock.h" @@ -419,7 +420,7 @@ return 0; } -static char *get_symlink_chunk(char *rpnt, struct rock_ridge *rr) +static char *get_symlink_chunk(char *rpnt, struct rock_ridge *rr, char *plimit) { int slen; int rootflag; @@ -431,16 +432,25 @@ rootflag = 0; switch (slp->flags & ~1) { case 0: + if (slp->len > plimit - rpnt) + return NULL; memcpy(rpnt, slp->text, slp->len); rpnt+=slp->len; break; + case 2: + if (rpnt >= plimit) + return NULL; + *rpnt++='.'; + break; case 4: + if (2 > plimit - rpnt) + return NULL; *rpnt++='.'; - /* fallthru */ - case 2: *rpnt++='.'; break; case 8: + if (rpnt >= plimit) + return NULL; rootflag = 1; *rpnt++='/'; break; @@ -457,17 +467,23 @@ * If there is another SL record, and this component * record isn't continued, then add a slash. */ - if ((!rootflag) && (rr->u.SL.flags & 1) && !(oldslp->flags & 1)) + if ((!rootflag) && (rr->u.SL.flags & 1) && + !(oldslp->flags & 1)) { + if (rpnt >= plimit) + return NULL; *rpnt++='/'; + } break; } /* * If this component record isn't continued, then append a '/'. */ - if (!rootflag && !(oldslp->flags & 1)) + if (!rootflag && !(oldslp->flags & 1)) { + if (rpnt >= plimit) + return NULL; *rpnt++='/'; - + } } return rpnt; } @@ -548,7 +564,10 @@ CHECK_SP(goto out); break; case SIG('S', 'L'): - rpnt = get_symlink_chunk(rpnt, rr); + rpnt = get_symlink_chunk(rpnt, rr, + link + (PAGE_SIZE - 1)); + if (rpnt == NULL) + goto out; break; case SIG('C', 'E'): /* This tells is if there is a continuation record */