diff options
| author |   Michał Górny <mgorny@gentoo.org> | 2019-11-03 08:52:07 +0100 |
|---|---|---|
| committer |   Göktürk Yüksek <gokturk@gentoo.org> | 2019-11-25 20:48:46 -0500 |
| commit | 49add11ae54e82cc38e51b2aaf22e06fedecb918 (patch) | |
| tree | b2db3facddb807f2343421454e92bb802c38ceea /ebuild-writing/variables/text.xml | |
| parent | quickstart: Update ctags HOMEPAGE to provide multi-value example (diff) | |
| download | devmanual-49add11ae54e82cc38e51b2aaf22e06fedecb918.tar.gz devmanual-49add11ae54e82cc38e51b2aaf22e06fedecb918.tar.bz2 devmanual-49add11ae54e82cc38e51b2aaf22e06fedecb918.zip | |
ebuild-writing/variables: explicitly discourage HOMEPAGE in SRC_URI
Closes: https://github.com/gentoo/devmanual/pull/115
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Göktürk Yüksek <gokturk@gentoo.org>
Diffstat (limited to 'ebuild-writing/variables/text.xml')
| -rw-r--r-- | ebuild-writing/variables/text.xml | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/ebuild-writing/variables/text.xml b/ebuild-writing/variables/text.xml index 8854a3a..35dc8f2 100644 --- a/ebuild-writing/variables/text.xml +++ b/ebuild-writing/variables/text.xml @@ -700,6 +700,11 @@ have no direct correlation with the expected string should be avoided. </li> <li> + using <c>${HOMEPAGE}</c> in <c>SRC_URI</c> — it breaks when homepage + changes or additional entry is added, + </li> + + <li> using <c>${PN}</c> (or other unnecessary helper variables) excessively in <c>src_install()</c> — it impairs readability for little benefit and causes a lot of trouble when the package needs to |