diff options
| author |   brahmajit das <brahmajit.xyz@gmail.com> | 2023-04-01 13:26:47 +0530 |
|---|---|---|
| committer |   Matt Turner <mattst88@gentoo.org> | 2023-04-10 08:37:52 -0400 |
| commit | ffa74c36cc92a3f4728892b8378e594df07028f6 (patch) | |
| tree | 87c91139ffd3b1ea9e4179dc93cccde1eaead279 /x11-libs/vte/files | |
| parent | app-metrics/go-carbon-0.17.1: fix tests, bug #904050 (diff) | |
| download | gentoo-ffa74c36cc92a3f4728892b8378e594df07028f6.tar.gz gentoo-ffa74c36cc92a3f4728892b8378e594df07028f6.tar.bz2 gentoo-ffa74c36cc92a3f4728892b8378e594df07028f6.zip | |
x11-libs/vte: Fix clang 16 build failure with -Wenum-constexpr-conversion
GSpawnFlags is enum with max value 1 << 15 which means it fits into a
short int, however here we are OR'ing VTE_SPAWN_* as well which have
higher values
Closes: https://bugs.gentoo.org/895834
Signed-off-by: brahmajit das <brahmajit.xyz@gmail.com>
Signed-off-by: Matt Turner <mattst88@gentoo.org>
Diffstat (limited to 'x11-libs/vte/files')
| -rw-r--r-- | x11-libs/vte/files/vte-0.70-integer-value-is-outside-the-valid-range-clang-16.patch | 47 |
1 files changed, 47 insertions, 0 deletions
diff --git a/x11-libs/vte/files/vte-0.70-integer-value-is-outside-the-valid-range-clang-16.patch b/x11-libs/vte/files/vte-0.70-integer-value-is-outside-the-valid-range-clang-16.patch new file mode 100644 index 000000000000..ab6aceae196c --- /dev/null +++ b/x11-libs/vte/files/vte-0.70-integer-value-is-outside-the-valid-range-clang-16.patch @@ -0,0 +1,47 @@ +# From 9400d41660e6c27b672f9c77855d736581f499bf Mon Sep 17 00:00:00 2001 +# From: Khem Raj <raj.khem@gmail.com> +# Date: Thu, 2 Mar 2023 22:57:00 +0100 +# Subject: [PATCH] pty: Do not typecast to GSpawnFlags +# +# GSpawnFlags is enum with max value 1 << 15 which means it fits into +# a short, however here we are oring VTE_SPAWN_* as well which have +# higher values (by design). This fixes a compile error on clang 16 +# with the -Wenum-constexpr-conversion flag. +# +# Fixes: https://gitlab.gnome.org/GNOME/vte/-/issues/2618 +# (cherry picked from commit 9b41cd1014299d01111b64b705f013e28398821a) +# +# Also refer: https://gitlab.gnome.org/GNOME/vte/-/commit/9400d41660e6c27b672f9c77855d736581f499bf.patch +--- a/src/vtepty.cc ++++ b/src/vtepty.cc +@@ -574,18 +574,18 @@ catch (...) + static constexpr inline auto + all_spawn_flags() noexcept + { +- return GSpawnFlags(G_SPAWN_LEAVE_DESCRIPTORS_OPEN | +- G_SPAWN_DO_NOT_REAP_CHILD | +- G_SPAWN_SEARCH_PATH | +- G_SPAWN_STDOUT_TO_DEV_NULL | +- G_SPAWN_STDERR_TO_DEV_NULL | +- G_SPAWN_CHILD_INHERITS_STDIN | +- G_SPAWN_FILE_AND_ARGV_ZERO | +- G_SPAWN_SEARCH_PATH_FROM_ENVP | +- G_SPAWN_CLOEXEC_PIPES | +- VTE_SPAWN_NO_PARENT_ENVV | +- VTE_SPAWN_NO_SYSTEMD_SCOPE | +- VTE_SPAWN_REQUIRE_SYSTEMD_SCOPE); ++ return (G_SPAWN_LEAVE_DESCRIPTORS_OPEN | ++ G_SPAWN_DO_NOT_REAP_CHILD | ++ G_SPAWN_SEARCH_PATH | ++ G_SPAWN_STDOUT_TO_DEV_NULL | ++ G_SPAWN_STDERR_TO_DEV_NULL | ++ G_SPAWN_CHILD_INHERITS_STDIN | ++ G_SPAWN_FILE_AND_ARGV_ZERO | ++ G_SPAWN_SEARCH_PATH_FROM_ENVP | ++ G_SPAWN_CLOEXEC_PIPES | ++ VTE_SPAWN_NO_PARENT_ENVV | ++ VTE_SPAWN_NO_SYSTEMD_SCOPE | ++ VTE_SPAWN_REQUIRE_SYSTEMD_SCOPE); + } + + static constexpr inline auto |