QA: Don't assign default to S; Default src_compile is fine because we have no configure script

Package-Manager: portage-2.0.51.22-r1

3 files changed, 24 insertions, 16 deletions

diff --git a/net-misc/astmanproxy/ChangeLog b/net-misc/astmanproxy/ChangeLog
index 8abb12850f24..a81ace002354 100644
--- a/net-misc/astmanproxy/ChangeLog
+++ b/net-misc/astmanproxy/ChangeLog
@@ -1,6 +1,10 @@
 # ChangeLog for net-misc/astmanproxy
 # Copyright 1999-2005 Gentoo Foundation; Distributed under the GPL v2
-# $Header: /var/cvsroot/gentoo-x86/net-misc/astmanproxy/ChangeLog,v 1.2 2005/07/13 09:17:10 dholm Exp $
+# $Header: /var/cvsroot/gentoo-x86/net-misc/astmanproxy/ChangeLog,v 1.3 2005/07/13 11:04:13 swegener Exp $
+
+  13 Jul 2005; Sven Wegener <swegener@gentoo.org> astmanproxy-1.1.ebuild:
+  QA: Don't assign default to S; Default src_compile is fine because we have
+  no configure script
 
   13 Jul 2005; David Holm <dholm@gentoo.org> astmanproxy-1.1.ebuild:
   Added to ~ppc.
diff --git a/net-misc/astmanproxy/Manifest b/net-misc/astmanproxy/Manifest
index 1c39121dfa82..98994597dcf3 100644
--- a/net-misc/astmanproxy/Manifest
+++ b/net-misc/astmanproxy/Manifest
@@ -1,6 +1,16 @@
-MD5 256e9d83c76a33cdd610a2ac813f3887 ChangeLog 502
-MD5 2e6709fc044b947a46b5b8b948a5f7d8 astmanproxy-1.1.ebuild 932
-MD5 44cf247f04cc83413fcb40ed59d0847a metadata.xml 248
+-----BEGIN PGP SIGNED MESSAGE-----
+Hash: SHA1
+
+MD5 5212a9bd42d2d6e16886a133dc8146e9 ChangeLog 679
+MD5 2b78ddf922db447f37f62bf7f3996a13 astmanproxy-1.1.ebuild 873
 MD5 4670d4323365e584a57d8bfb44139d9b files/astmanproxy-1.1-gentoo.diff 1051
 MD5 f368b0dbbb0802aed2ce900086e5982a files/astmanproxy.rc6 480
 MD5 5bbca9db1db666ffad0f311a8e144f3a files/digest-astmanproxy-1.1 77
+MD5 44cf247f04cc83413fcb40ed59d0847a metadata.xml 248
+-----BEGIN PGP SIGNATURE-----
+Version: GnuPG v1.4.1 (GNU/Linux)
+
+iD8DBQFC1PVLI1lqEGTUzyQRAt/AAJ9ZTskTLXNRpsMTex0sXip0sslNYQCfa5y1
+sfmopJcY4A2aR8/pkbzP3Uo=
+=LLnc
+-----END PGP SIGNATURE-----
diff --git a/net-misc/astmanproxy/astmanproxy-1.1.ebuild b/net-misc/astmanproxy/astmanproxy-1.1.ebuild
index ea991c286c63..815ad177f4f3 100644
--- a/net-misc/astmanproxy/astmanproxy-1.1.ebuild
+++ b/net-misc/astmanproxy/astmanproxy-1.1.ebuild
@@ -1,6 +1,6 @@
 # Copyright 1999-2005 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/net-misc/astmanproxy/astmanproxy-1.1.ebuild,v 1.2 2005/07/13 09:17:10 dholm Exp $
+# $Header: /var/cvsroot/gentoo-x86/net-misc/astmanproxy/astmanproxy-1.1.ebuild,v 1.3 2005/07/13 11:04:13 swegener Exp $
 
 inherit eutils
 
@@ -16,22 +16,16 @@ KEYWORDS="~ppc ~x86"
 
 DEPEND="virtual/libc"
 
-S=${WORKDIR}/${P}
-
 src_unpack() {
 	unpack ${A}
+	cd "${S}"
 
-	cd ${S}
 	# small patch for cflags and path changes
-	epatch ${FILESDIR}/${P}-gentoo.diff
-}
-
-src_compile() {
-	emake || die "emake failed"
+	epatch "${FILESDIR}"/${P}-gentoo.diff
 }
 
 src_install() {
-	make DESTDIR=${D} install || die
+	make DESTDIR="${D}" install || die
 
 	dodoc README README.* VERSIONS astmanproxy.conf
 
@@ -39,7 +33,7 @@ src_install() {
 	dodoc samples/*
 
 	# fix permissions on config file
-	chmod 0640 ${D}/etc/astmanproxy.conf
+	fperms 0640 /etc/astmanproxy.conf
 
-	newinitd ${FILESDIR}/astmanproxy.rc6 astmanproxy
+	newinitd "${FILESDIR}"/astmanproxy.rc6 astmanproxy
 }