media-sound/mixxx: optimise SRC_URI generation

Thanks to radhermit's new pkgcraft tooling.

Before:
```
media-sound/mixxx-9999::/home/sam/g/: 11.417694ms
media-sound/mixxx-2.3.5-r1::/home/sam/g/: 27.881683ms
media-sound/mixxx-2.3.3-r1::/home/sam/g/: 29.44105ms
media-sound/mixxx-2.3.9999::/home/sam/g/: 30.059357ms
```

After:
```
media-sound/mixxx-2.3.5-r1::/home/sam/g/: 9.490994ms
media-sound/mixxx-2.3.3-r1::/home/sam/g/: 9.668916ms
media-sound/mixxx-2.3.9999::/home/sam/g/: 11.079521ms
media-sound/mixxx-9999::/home/sam/g/: 11.424654ms
```

Signed-off-by: Sam James <sam@gentoo.org>

3 files changed, 16 insertions, 13 deletions

diff --git a/media-sound/mixxx/mixxx-2.3.3-r1.ebuild b/media-sound/mixxx/mixxx-2.3.3-r1.ebuild
index dd7a1e9e57b2..f5cbf9720882 100644
--- a/media-sound/mixxx/mixxx-2.3.3-r1.ebuild
+++ b/media-sound/mixxx/mixxx-2.3.3-r1.ebuild
@@ -1,10 +1,11 @@
-# Copyright 1999-2022 Gentoo Authors
+# Copyright 1999-2023 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
 EAPI=8
 
 inherit cmake xdg udev
 
+MY_PV=$(ver_cut 1-2)
 DESCRIPTION="Advanced Digital DJ tool based on Qt"
 HOMEPAGE="https://www.mixxx.org/"
 if [[ "${PV}" == *9999 ]] ; then
@@ -97,12 +98,12 @@ PLOCALES="
 
 mixxx_set_globals() {
 	local lang
-	local MANUAL_URI_BASE="https://downloads.mixxx.org/manual/$(ver_cut 1-2)"
+	local MANUAL_URI_BASE="https://downloads.mixxx.org/manual/${MY_PV}"
 	for lang in ${PLOCALES} ; do
-		SRC_URI+=" l10n_${lang}? ( ${MANUAL_URI_BASE}/${PN}-manual-$(ver_cut 1-2)-${lang/ja/ja-JP}.pdf )"
+		SRC_URI+=" l10n_${lang}? ( ${MANUAL_URI_BASE}/${PN}-manual-${MY_PV}-${lang/ja/ja-JP}.pdf )"
 		IUSE+=" l10n_${lang/ en/ +en}"
 	done
-	SRC_URI+=" ${MANUAL_URI_BASE}/${PN}-manual-$(ver_cut 1-2)-en.pdf"
+	SRC_URI+=" ${MANUAL_URI_BASE}/${PN}-manual-${MY_PV}-en.pdf"
 }
 mixxx_set_globals
 
@@ -151,7 +152,7 @@ src_install() {
 	local locale
 	for locale in ${PLOCALES} ; do
 		if use l10n_${locale} ; then
-			dodoc "${DISTDIR}"/${PN}-manual-$(ver_cut 1-2)-${locale/ja/ja-JP}.pdf
+			dodoc "${DISTDIR}"/${PN}-manual-${MY_PV}-${locale/ja/ja-JP}.pdf
 		fi
 	done
 }
diff --git a/media-sound/mixxx/mixxx-2.3.5-r1.ebuild b/media-sound/mixxx/mixxx-2.3.5-r1.ebuild
index 4481a0c531b5..fba6b6470a4e 100644
--- a/media-sound/mixxx/mixxx-2.3.5-r1.ebuild
+++ b/media-sound/mixxx/mixxx-2.3.5-r1.ebuild
@@ -5,6 +5,7 @@ EAPI=8
 
 inherit cmake xdg udev
 
+MY_PV=$(ver_cut 1-2)
 DESCRIPTION="Advanced Digital DJ tool based on Qt"
 HOMEPAGE="https://mixxx.org/"
 if [[ ${PV} == *9999 ]] ; then
@@ -99,12 +100,12 @@ PLOCALES="
 
 mixxx_set_globals() {
 	local lang
-	local MANUAL_URI_BASE="https://downloads.mixxx.org/manual/$(ver_cut 1-2)"
+	local MANUAL_URI_BASE="https://downloads.mixxx.org/manual/${MY_PV}"
 	for lang in ${PLOCALES} ; do
-		SRC_URI+=" l10n_${lang}? ( ${MANUAL_URI_BASE}/${PN}-manual-$(ver_cut 1-2)-${lang/ja/ja-JP}.pdf )"
+		SRC_URI+=" l10n_${lang}? ( ${MANUAL_URI_BASE}/${PN}-manual-${MY_PV}-${lang/ja/ja-JP}.pdf )"
 		IUSE+=" l10n_${lang/ en/ +en}"
 	done
-	SRC_URI+=" ${MANUAL_URI_BASE}/${PN}-manual-$(ver_cut 1-2)-en.pdf"
+	SRC_URI+=" ${MANUAL_URI_BASE}/${PN}-manual-${MY_PV}-en.pdf"
 }
 mixxx_set_globals
 
@@ -144,7 +145,7 @@ src_install() {
 	local locale
 	for locale in ${PLOCALES} ; do
 		if use l10n_${locale} ; then
-			dodoc "${DISTDIR}"/${PN}-manual-$(ver_cut 1-2)-${locale/ja/ja-JP}.pdf
+			dodoc "${DISTDIR}"/${PN}-manual-${MY_PV}-${locale/ja/ja-JP}.pdf
 		fi
 	done
 }
diff --git a/media-sound/mixxx/mixxx-2.3.9999.ebuild b/media-sound/mixxx/mixxx-2.3.9999.ebuild
index 8e68e926a377..55d859df3021 100644
--- a/media-sound/mixxx/mixxx-2.3.9999.ebuild
+++ b/media-sound/mixxx/mixxx-2.3.9999.ebuild
@@ -5,6 +5,7 @@ EAPI=8
 
 inherit cmake xdg udev
 
+MY_PV=$(ver_cut 1-2)
 DESCRIPTION="Advanced Digital DJ tool based on Qt"
 HOMEPAGE="https://mixxx.org/"
 if [[ ${PV} == *9999 ]] ; then
@@ -97,12 +98,12 @@ PLOCALES="
 
 mixxx_set_globals() {
 	local lang
-	local MANUAL_URI_BASE="https://downloads.mixxx.org/manual/$(ver_cut 1-2)"
+	local MANUAL_URI_BASE="https://downloads.mixxx.org/manual/${MY_PV}"
 	for lang in ${PLOCALES} ; do
-		SRC_URI+=" l10n_${lang}? ( ${MANUAL_URI_BASE}/${PN}-manual-$(ver_cut 1-2)-${lang/ja/ja-JP}.pdf )"
+		SRC_URI+=" l10n_${lang}? ( ${MANUAL_URI_BASE}/${PN}-manual-${MY_PV}-${lang/ja/ja-JP}.pdf )"
 		IUSE+=" l10n_${lang/ en/ +en}"
 	done
-	SRC_URI+=" ${MANUAL_URI_BASE}/${PN}-manual-$(ver_cut 1-2)-en.pdf"
+	SRC_URI+=" ${MANUAL_URI_BASE}/${PN}-manual-${MY_PV}-en.pdf"
 }
 mixxx_set_globals
 
@@ -142,7 +143,7 @@ src_install() {
 	local locale
 	for locale in ${PLOCALES} ; do
 		if use l10n_${locale} ; then
-			dodoc "${DISTDIR}"/${PN}-manual-$(ver_cut 1-2)-${locale/ja/ja-JP}.pdf
+			dodoc "${DISTDIR}"/${PN}-manual-${MY_PV}-${locale/ja/ja-JP}.pdf
 		fi
 	done
 }